gh-149694: Fix missing docstring on asyncio.iscoroutinefunction#149695
Closed
deadlovelll wants to merge 1 commit into
Closed
gh-149694: Fix missing docstring on asyncio.iscoroutinefunction#149695deadlovelll wants to merge 1 commit into
deadlovelll wants to merge 1 commit into
Conversation
…misplaced import statement
deadlovelll
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
We are in the process of removing this function. So, this PR should be opened against 3.15 instead (I'm closing it because it's easier to recreate a branch from 3.15 rather than rebasing) |
Contributor
Author
Okay, i'll recreate this for 3.15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-149694: Fix missing docstring on asyncio.iscoroutinefunction
The docstring in
asyncio.iscoroutinefunctionis currently dead code: it follows animport warningsstatement, so Python does not treat it as docstring.Before:
After:
The fix is a one-line reorder: move import warnings below the docstring.